Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu: aarch64: improve memory management safety for jit_uni_softmax #2126

Merged

Conversation

Permanence-AI-Coder
Copy link
Contributor

Description

The code changes in this PR were generated automatically by the Permanence AI Coder and reviewed by @fwph & @jweese. This PR updates memory allocation for softmax_driver_ objects in two structs. Note that in the macro DNNL_DISALLOW_COPY_AND_ASSIGN was missing; it has been added to be consistent with other objects.

on-behalf-of: @permanence-ai github-ai@permanence.ai

Checklist

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • Have you formatted the code using clang-format?

@Permanence-AI-Coder Permanence-AI-Coder requested a review from a team as a code owner September 26, 2024 17:03
@github-actions github-actions bot added the platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 label Sep 26, 2024
@Sqvid Sqvid self-requested a review October 1, 2024 12:42
@spalicki
Copy link
Contributor

spalicki commented Oct 1, 2024

@Sqvid You have approved this change and then re requested a review on yourself, do you want more time for this review?

@theComputeKid
Copy link
Contributor

@spalicki Could you clarify why we are modifying to utils::make_unique instead of using the std lib? Seems like a pattern, but still, wanted to clarify.

@dzarukin
Copy link
Contributor

dzarukin commented Oct 1, 2024

@spalicki Could you clarify why we are modifying to utils::make_unique instead of using the std lib? Seems like a pattern, but still, wanted to clarify.

std lib version is available only from C++14, while by default oneDNN gets compiled with C++11. That's the primary reason.

@spalicki
Copy link
Contributor

spalicki commented Oct 1, 2024

std::make_unique is not part of C++11, only C++14.

@spalicki spalicki merged commit 51e5dab into oneapi-src:main Oct 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants