Skip to content

Commit

Permalink
cpu: x64: fix assertion in bf16 conv for relo on AMX
Browse files Browse the repository at this point in the history
  • Loading branch information
xuxinzen authored and tprimak committed May 24, 2024
1 parent 955fe7b commit a97f021
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/cpu/x64/jit_avx512_core_amx_conv_kernel.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,8 @@ void jit_avx512_core_amx_copy_to_pbuffer_t::copy_row(int icb) {

void jit_avx512_core_amx_copy_to_pbuffer_t::copy_row_reduced_lowering() {
assert(jcp.nb_ic_int == 1);
assert(jcp.ic_block_int * jcp.typesize_in == 64);
assert((jcp.is_bf32 ? jcp.ic_block : jcp.ic_block_int) * jcp.typesize_in
== 64);
assert(jcp.is_nspc);

auto load_mask = [this](int tail, Opmask kmask) {
Expand Down
1 change: 1 addition & 0 deletions src/cpu/x64/jit_brgemm_conv.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -977,6 +977,7 @@ status_t brgemm_convolution_fwd_t<isa, use_inversion>::init(engine_t *engine) {
ajcp.is_relo = true;
ajcp.nb_ic_int = 1;
ajcp.is_nspc = true;
ajcp.is_bf32 = jcp.is_bf32;
ajcp.typesize_in = jcp.src_dsz;
ajcp.ic_block_int = jcp.amx_w;

Expand Down
1 change: 1 addition & 0 deletions src/cpu/x64/jit_primitive_conf.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ struct jit_conv_conf_t {
data_type_t ddst_dt;
data_type_t dsrc_dt;
data_type_t dwei_dt;
bool is_bf32 {false};
bool expl_bcast;
bool large_spatial, large_w_filter;
int is_ic_scale, is_oc_scale;
Expand Down

0 comments on commit a97f021

Please sign in to comment.