Skip to content

Update lpot2inc ONSAM-1443 #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 7, 2021
Merged

Update lpot2inc ONSAM-1443 #784

merged 11 commits into from
Dec 7, 2021

Conversation

NeoZhangJianyu
Copy link
Contributor

Existing Sample Changes

Description

Fixes Issue#ONSAM-1443

LPOT is renamed to INC, change text and code for it.
Change the test env. installation script to use same python version in oneAPI.

External Dependencies

List any external dependencies created as a result of this change.

Type of change

Please delete options that are not relevant. Add a 'X' to the one that is applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Implement fixes for ONSAM Jiras

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Command Line
  • oneapi-cli
  • Visual Studio
  • Eclipse IDE
  • VSCode
  • When compiling the compliler flag "-Wall -Wformat-security -Werror=format-security" was used

Delete this line and everything below if this is not a PR for a new code sample

Delete this line and all above it if this PR is for a new code sample

Adding a New Sample(s)

Description

Please include a description of the sample

Checklist

Administrative

  • Review sample design with the appropriate Domain Expert:
  • If you have any new dependencies/binaries, inform the oneAPI Code Samples Project Manager: @JoeOster

Code Development

Security and Legal

  • OSPDT Approval (see @JoeOster for assistance)
  • Compile using the following compiler flags and fix any warnings, the falgs are: "/Wall -Wformat-security -Werror=format-security"
  • Bandit Scans (Python only)
  • Virus scan

Review

  • Review DPC++ code with Paul Peterseon. (GitHub User: pmpeter1)
  • Review readme with Tom Lenth(@tomlenth) and/or Joe Oster(@JoeOster)
  • Tested using Dev Cloud when applicable

JoeOster and others added 9 commits September 29, 2021 09:45
* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp
add install flatbuffers
add missed package used in TF2.5
Copy link
Contributor

@praveenkk123 praveenkk123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for CI

"env": ["source ${ONEAPI_ROOT}/setvars.sh --force",
"conda env remove -n user_tensorflow",
"conda create -n user_tensorflow -c ${ONEAPI_ROOT}/conda_channel python=`python -V| awk '{print $2}'` -y",
"conda activate user_tensorfinclow",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"conda activate user_tensorfinclow",
"conda activate user_tensorflow",

Copy link
Contributor

@praveenkk123 praveenkk123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for CI

@praveenkk123 praveenkk123 merged commit 5829f29 into oneapi-src:development Dec 7, 2021
praveenkk123 pushed a commit that referenced this pull request Dec 7, 2021
* ONSAM-1414 Broken Link in Headers (#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (#682)

* rm plus, Fixes Issue#ONSAM-1418

* Update sample.json

add install flatbuffers

* Update sample.json

add missed package used in TF2.5

* update according to the review comment

make code be better

* rename lpot to inc

* fix sample.json error and use full name of INC

* use full name to replace INC, format sample.json

Co-authored-by: JoeOster <52936608+JoeOster@users.noreply.github.com>
Co-authored-by: ericlars <eric.larson@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants