-
Notifications
You must be signed in to change notification settings - Fork 729
ONSAM-1419 - fixed sample still using deprecated namespace sycl::ONEAPI #726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vmadanan <varsha.madananth@intel.com>
* Update Makefile * Update Makefile * Update Makefile * Update DCT.hpp * Update intrin_ftz_sample.cpp * Update merge_sort.cpp * Update intrin_double_sample.cpp * Update intrin_dot_sample.cpp * Update DCT.cpp
Signed-off-by: vmadanan <varsha.madananth@intel.com>
HI Varsha, Thanks |
Created a merge request to development branch |
praveenkk123
approved these changes
Nov 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve for CI
praveenkk123
approved these changes
Nov 2, 2021
praveenkk123
pushed a commit
that referenced
this pull request
Dec 7, 2021
…PI (#726) * Adding mandelbrot sample to the repository Signed-off-by: vmadanan <varsha.madananth@intel.com> * Adding changes to mandelbrot to remove libsycl-complex.so dependency * namespace change for Monte Carlo * Updated samples to newest coding guidelines * Updating samples- Mandelbrot, DCT and MonteCarlo with newest coding guidelines * Fixing warnings for DCT * Added ifdef to remove warnings * Fixed issues with mandelbrot/montecarlopi in debug/release * ONSAM-1414 Broken Link in Headers (#685) * Update Makefile * Update Makefile * Update Makefile * Update DCT.hpp * Update intrin_ftz_sample.cpp * Update merge_sort.cpp * Update intrin_double_sample.cpp * Update intrin_dot_sample.cpp * Update DCT.cpp * fix deprecation notice (#682) * Fixed warnings on using deprecated namespace sycl::ONEAPI Signed-off-by: vmadanan <varsha.madananth@intel.com> Co-authored-by: varsha madananth <vmadananth@gmail.com> Co-authored-by: JoeOster <52936608+JoeOster@users.noreply.github.com> Co-authored-by: ericlars <eric.larson@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing Sample Changes
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes Issue#
External Dependencies
List any external dependencies created as a result of this change.
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Delete this line and everything below if this is not a PR for a new code sample
Delete this line and all above it if this PR is for a new code sample
Adding a New Sample(s)
Description
Please include a description of the sample
Checklist
Administrative
Code Development
Security and Legal
Review