Skip to content

Remove oneVPL sample source #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 2, 2021
Merged

Remove oneVPL sample source #705

merged 6 commits into from
Nov 2, 2021

Conversation

jeffreymcallister
Copy link
Contributor

@jeffreymcallister jeffreymcallister commented Oct 14, 2021

Existing Sample Changes

Description

Remove oneVPL sample code, which will be stored in oneVPL dispatcher repo instead. Following oneDNN pattern.

Fixes Issue# VPL7-1769

External Dependencies

None

Type of change

Please delete options that are not relevant. Add a 'X' to the one that is applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Implement fixes for ONSAM Jiras

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Command Line
  • oneapi-cli
  • Visual Studio
  • Eclipse IDE
  • VSCode
  • When compiling the compliler flag "-Wall -Wformat-security -Werror=format-security" was used

Delete this line and everything below if this is not a PR for a new code sample

JoeOster and others added 2 commits September 29, 2021 09:45
* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp
Copy link
Contributor

@praveenkk123 praveenkk123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for CI purposes only

@praveenkk123 praveenkk123 requested a review from tomlenth October 14, 2021 21:05
@jeffreymcallister jeffreymcallister marked this pull request as ready for review October 17, 2021 20:31
Copy link
Contributor

@praveenkk123 praveenkk123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for CI

@jeffreymcallister
Copy link
Contributor Author

Validation fails expected until samples are added to oneVPL directories.

@jeffreymcallister
Copy link
Contributor Author

jeffreymcallister commented Oct 21, 2021

Updated so that oneAPI samples validation can pass while changes to oneVPL repo are in flight. @praveenkk123: Can you start CI again?

Copy link
Contributor

@praveenkk123 praveenkk123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for CI only

Copy link
Contributor

@praveenkk123 praveenkk123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for CI

@praveenkk123 praveenkk123 merged commit ef9387c into oneapi-src:development Nov 2, 2021
praveenkk123 added a commit that referenced this pull request Dec 7, 2021
* ONSAM-1414 Broken Link in Headers (#685)

* Update Makefile

* Update Makefile

* Update Makefile

* Update DCT.hpp

* Update intrin_ftz_sample.cpp

* Update merge_sort.cpp

* Update intrin_double_sample.cpp

* Update intrin_dot_sample.cpp

* Update DCT.cpp

* fix deprecation notice (#682)

* Remove oneVPL sample source

* Update json

Co-authored-by: JoeOster <52936608+JoeOster@users.noreply.github.com>
Co-authored-by: ericlars <eric.larson@intel.com>
Co-authored-by: praveenkk123 <praveen.k.kundurthy@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants