Skip to content

fix ONSAM-1387, it's workaround for LPOT new bug #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2021
Merged

fix ONSAM-1387, it's workaround for LPOT new bug #573

merged 1 commit into from
Jun 30, 2021

Conversation

NeoZhangJianyu
Copy link
Contributor

@NeoZhangJianyu NeoZhangJianyu commented Jun 30, 2021

Existing Sample Changes

Description

fix ONSAM-1387, it's a workaround for LPOT new bug: https://jira.devtools.intel.com/browse/ILITV-743 Timeout mechanism bug fix.

When the bug is fixed, the sample code will be restored to enable timeout.

Fixes Issue#

External Dependencies

List any external dependencies created as a result of this change.

Type of change

Please delete options that are not relevant. Add a 'X' to the one that is applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Implement fixes for ONSAM Jiras

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Command Line
  • oneapi-cli
  • Visual Studio
  • Eclipse IDE
  • VSCode
  • When compiling the compliler flag "-Wall -Wformat-security -Werror=format-security" was used

Copy link

@ebirent ebirent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PV test passed with 2021.3 RTM toolkits installed.

@JoeOster JoeOster self-requested a review June 30, 2021 11:23
@@ -354,7 +363,7 @@
},
"outputs": [],
"source": [
"!python lpot_quantize_model.py"
"!TF_ENABLE_MKL_NATIVE_FORMAT=0 python lpot_quantize_model.py"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
Do we need TF_ENABLE_MKL_NATIVE_FORMAT=0 if we have export it via the cell before this one?
maybe we only need to have either one of them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.
But due to this variable is mandatory to LPOT now, I want to high light it in the cmd.
Sometime, user will copy the cmd line in new term to run it. Maybe the current cmd is easy to copy/paste and avoid to miss the variable setting.

@JoeOster JoeOster merged commit 0494db8 into oneapi-src:master Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants