Skip to content

Create CODEOWNERS #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 11, 2020
Merged

Create CODEOWNERS #4

merged 3 commits into from
Jul 11, 2020

Conversation

anjgola
Copy link
Contributor

@anjgola anjgola commented Jun 29, 2020

No description provided.

@anjgola anjgola requested a review from mkitez June 29, 2020 23:19
This list is being reviwed right now
@samples-ci samples-ci requested review from samples-ci and removed request for samples-ci June 29, 2020 23:53
CODEOWNERS Outdated
/Libraries/ @JoeOster @Propanu @mav-intel @JoeOster

# Reviwers for all sample.json modification
*sample.json @pfische1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add myself here as well? I would like to be aware of the ciTests field changes in particular

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@anjgola anjgola marked this pull request as draft July 7, 2020 01:18
@anjgola
Copy link
Contributor Author

anjgola commented Jul 8, 2020

@mkitez I can use your help regarding this PR. I haven't merged this because it is not a good solution and I feel stuck on how to proceed.
Github codeowners conditions are not aggregated and only the last condition met is applied. That means if someone edits a sample.json and a README.md file, then whatever condition I list at the end of this file will be executed. This doesn't help.
I see this article that solves a similar problem : https://bionic.fullstory.com/taming-github-codeowners-with-bots/
Do you think we need to do something like this?

In short term, we could just go with 3-4 blanket reviewers for all files for now but we need a better solution.

@mkitez
Copy link
Contributor

mkitez commented Jul 9, 2020

@anjgola sounds good. Let's go with what you suggested for now, we can look into the approach described in the article moving forward.

@anjgola anjgola marked this pull request as ready for review July 9, 2020 23:44
@anjgola anjgola merged commit 751143f into master Jul 11, 2020
@anjgola anjgola deleted the anjgola-patch-1 branch July 13, 2020 22:44
mvincerx added a commit that referenced this pull request Nov 9, 2023
- For Expertise, Language, TargetDevice, only  1 option allowed; like radio buttons
- Upon selection/deselection for Filter checkboxes, DOM state is reset ...
- ...and reflects that last-checked checkbox, where app states auto-refreshes
- Changes layout of Filter dropdown to remove empty space below it; add space after toolkit-cards
- Adds home button in navbar, upper left, to improve user nav and ...
- ... adds JS functions to manage and reload state when home clicked or filter reset clicked.
- Fixes Defect #4, reported date 07/21/2023, assigned 10/3/2023 to michael vincerra, app developer

Signed-off-by: michael vincerra <michael.vincerra@intel.com>
jimmytwei pushed a commit that referenced this pull request Jun 6, 2025
* uv for IntelTensorFlow_for_LLMs.
* uv for leveraging-intel-extension-for-tensorFlow-with-LSTM-for-text-generation
* uv for IntelTensorFlow_Horovod_Distributed_Deep_Learning
* uv for IntelTensorFlow_ModelZoo_Inference_with_FP32_Int8
* uv for IntelTensorFlow_PerformanceAnalysis
* add uv to IntelPython_XGBoost_daal4pyPrediction
* finished sample IntelTensorFlow_Enabling_Auto_Mixed_Precision_for_TransferLearning
* finished converting IntelPython_daal4py_DistributedLinearRegression
* finished converting IntelPython_daal4py_GettingStarted
* uv added to IntelPython_daal4py_DistributedKMeans
* uv for intelpython-xgboost-gettingstarted
* uv for intelTensorFlow_gettingstarted
* uv for moding_gettingstarted
* adding uv for moding_vs_pandas
* finished converting JobRecommendationSystem sample

---------
Signed-off-by: Solano Saurez, Hector <hector.solano.saurez@intel.com>
Co-authored-by: Allan Mora B <allan.mora.brenes@intel.com>
Co-authored-by: Mora Jimenez, Kevin <kevin.mora.jimenez@intel.com>
Co-authored-by: Edgar Parra <edgar.parra.barillas@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants