Skip to content

Create makefile for NMAKE to build and run on windows #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2020
Merged

Create makefile for NMAKE to build and run on windows #271

merged 4 commits into from
Oct 23, 2020

Conversation

Alberto-Villarreal
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # code sample not running using Visual Studio

Type of change

Please delete options that are not relevant. Add a 'X' to the one that is applicable.

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Sample Migration (Moving sample from old repository after completing checklist established)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x ] Command Line
  • [ x] oneapi-cli
  • Visual Studio
  • Eclipse IDE
  • VSCode

Checklist for Moving samples:

Links and Details can be found in the samples WG Teams Files.

Alberto Villarreal added 4 commits October 22, 2020 16:49
Signed-off-by: Alberto Villarreal <avillarr@SSEC-HDC02.jf.intel.com>
Signed-off-by: Alberto Villarreal <avillarr@SSEC-HDC02.jf.intel.com>
Signed-off-by: Alberto Villarreal <avillarr@SSEC-HDC02.jf.intel.com>
Signed-off-by: Alberto Villarreal <avillarr@SSEC-HDC02.jf.intel.com>
Copy link
Contributor

@JoeOster JoeOster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving for ci

@Alberto-Villarreal
Copy link
Contributor Author

Source code not changed (already approved for coding guidelines).
In this MR: VS project files were removed and a makefile for NMAKE was added instead

@JoeOster JoeOster merged commit a8b6d2b into oneapi-src:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants