FPGA: use DEFINED in cmake to allow for values set to 0 #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing Sample Changes
Description
This change changes how the
cmakefiles in the qrd/qri/cholesky/cholesky_inversion designs check ifcmakevariables are defined.It used to check if a
cmakevariable was defined usingif(<VAR>) ...which was ignored if that variable was set to 0.This change therefore checks for such variables using
if(DEFINED <VAR>)which allows for this variable to be defined, and equal to 0.Fixes Issue#
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.