[SYCLomatic] Enable migration for CUBLASLT_EPILOGUE_DGELU & EPILOGUE_BGRADB #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiweij1
reviewed
Nov 6, 2024
| float alpha, float beta) { | ||
|
|
||
| auto alg = ::dnnl::algorithm::eltwise_gelu_erf; | ||
| const memory_desc_ext &dst_desc = new memory_desc_ext(); |
There was a problem hiding this comment.
where to "delete" dst_desc and src_desc?
zhiweij1
reviewed
Nov 6, 2024
zhiweij1
reviewed
Nov 6, 2024
| @@ -44,6 +44,19 @@ using matmul_desc_ptr = matmul_desc_t *; | |||
| class transform_desc_t; | |||
| using transform_desc_ptr = transform_desc_t *; | |||
|
|
|||
| template <typename primitive_type, typename... args_type> | |||
| inline | |||
| typename primitive_type::primitive_desc dgelu_epilogue_( | |||
There was a problem hiding this comment.
The function name looks like a type name, please refine it.
zhiweij1
reviewed
Nov 6, 2024
| const memory_desc_ext &dst_desc = new memory_desc_ext(); | ||
| const memory_desc_ext &src_desc = new memory_desc_ext(); | ||
| return create_primitive_desc<primitive_type>( | ||
| ::dnnl::prop_kind::backward, alg, src_desc.get_desc(), |
There was a problem hiding this comment.
For src_desc and dst_desc, is it OK to pass to the create_primitive_desc directly?
No need to fill data?
zhiweij1
reviewed
Nov 6, 2024
zhiweij1
reviewed
Nov 6, 2024
zhiweij1
reviewed
Nov 6, 2024
zhiweij1
reviewed
Nov 6, 2024
zhiweij1
reviewed
Nov 6, 2024
zhiweij1
reviewed
Nov 6, 2024
zhiweij1
reviewed
Nov 6, 2024
abhilash1910
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zhiweij1 @zhimingwang36
(WIP)