Fix compilation error in src/backend/image.ts that blob can be null#180
Open
superkelvint wants to merge 1 commit intoondras:masterfrom
Open
Fix compilation error in src/backend/image.ts that blob can be null#180superkelvint wants to merge 1 commit intoondras:masterfrom
superkelvint wants to merge 1 commit intoondras:masterfrom
Conversation
Owner
|
Hi @superkelvint , thanks for the PR. Are you aware of a particular situation where the |
Author
|
No I'm not. I just had to make this change in order to build. Not sure why.
Anyway, thank you so much for this wonderful library/application. I love
the keyboard shortcuts and how everything is designed.
…On Mon, Jun 10, 2024, 04:26 Ondřej Žára ***@***.***> wrote:
Hi @superkelvint <https://github.com/superkelvint> ,
thanks for the PR. Are you aware of a particular situation where the
toBlob fails to export the canvas? As far as I know, this would only
happen with unsupported image format (and based on my experiments, browser
just simply coerce to image/png instead).
—
Reply to this email directly, view it on GitHub
<#180 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFBLXMCENBLDEYAG23WO33ZGWEMRAVCNFSM6AAAAABI5CNPE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJYGA4DEMBTG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Owner
|
Well, if we think that there is no reason for URL.createObjectURL(blob!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compilation error was: