Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate StructureMap #281

Merged
merged 32 commits into from
Oct 23, 2024
Merged

Validate StructureMap #281

merged 32 commits into from
Oct 23, 2024

Conversation

Wambere
Copy link
Contributor

@Wambere Wambere commented Aug 30, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #199

Engineer Checklist

  • I have run ./gradlew spotlessApply to check my code follows the project's style guide
  • I have built and run the efsity jar to verify my change fixes the issue and/or does not break the application

@Wambere Wambere added the efsity FCT features label Aug 30, 2024
@sharon2719 sharon2719 marked this pull request as ready for review October 14, 2024 14:30
@sharon2719 sharon2719 enabled auto-merge (squash) October 16, 2024 12:39
efsity/README.md Outdated Show resolved Hide resolved
@ndegwamartin
Copy link
Contributor

Tested it out and it returns a successful validation even when I give it an incorrect questionnaire json file path

@ndegwamartin
Copy link
Contributor

Additionally appears as part of validation it tries to connect to the FHIR Base URL server defined for the QuestionnaireResponse generated here for validation - https://github.com/onaio/fhir-tooling/blob/199-validate-sm/efsity/src/main/java/org/smartregister/command/ValidateStructureMapCommand.java#L106-L115 leading to the exception here :

Screenshot 2024-10-17 at 19 10 03

@ndegwamartin
Copy link
Contributor

Additionally we should refactor to remove duplicates across the project or move any potentially reusable code to util classes

@sharon2719
Copy link
Contributor

Additionally appears as part of validation it tries to connect to the FHIR Base URL server defined for the QuestionnaireResponse generated here for validation - https://github.com/onaio/fhir-tooling/blob/199-validate-sm/efsity/src/main/java/org/smartregister/command/ValidateStructureMapCommand.java#L106-L115 leading to the exception here :

Screenshot 2024-10-17 at 19 10 03

For this to run you need to have the hapi-fhir-jpaserver running locally. I have included this information in the ReadMe.

}

// Define the directory name for generated resources
String directoryName = "generatedResources";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a note we don't need to make any changes, would be nice to move this to a constant if there's an obvious way or maybe as an arg to this function with a the constant as the default value (I don't remember if that's a thing you can do in java :D)

efsity/README.md Outdated Show resolved Hide resolved
@ndegwamartin
Copy link
Contributor

Additionally appears as part of validation it tries to connect to the FHIR Base URL server defined for the QuestionnaireResponse generated here for validation - https://github.com/onaio/fhir-tooling/blob/199-validate-sm/efsity/src/main/java/org/smartregister/command/ValidateStructureMapCommand.java#L106-L115 leading to the exception here :
Screenshot 2024-10-17 at 19 10 03

For this to run you need to have the hapi-fhir-jpaserver running locally. I have included this information in the ReadMe.

Since we intend to run this via CI for the automation how do we intent to handle this case?

@sharon2719 sharon2719 merged commit a70d0cb into main Oct 23, 2024
4 checks passed
@sharon2719 sharon2719 deleted the 199-validate-sm branch October 23, 2024 13:26
@pld pld changed the title WIP: Validate StructureMap Validate StructureMap Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
efsity FCT features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate StructureMaps based on connection to Questionnaires
4 participants