-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate StructureMap #281
Conversation
379ed9e
to
b5bb97b
Compare
efsity/src/main/java/org/smartregister/command/ValidateStructureMapCommand.java
Outdated
Show resolved
Hide resolved
efsity/src/main/java/org/smartregister/command/ValidateStructureMapCommand.java
Show resolved
Hide resolved
Tested it out and it returns a successful validation even when I give it an incorrect questionnaire json file path |
Additionally appears as part of validation it tries to connect to the FHIR Base URL server defined for the |
Additionally we should refactor to remove duplicates across the project or move any potentially reusable code to util classes |
For this to run you need to have the |
efsity/src/main/java/org/smartregister/command/ValidateStructureMapCommand.java
Outdated
Show resolved
Hide resolved
} | ||
|
||
// Define the directory name for generated resources | ||
String directoryName = "generatedResources"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only a note we don't need to make any changes, would be nice to move this to a constant if there's an obvious way or maybe as an arg to this function with a the constant as the default value (I don't remember if that's a thing you can do in java :D)
efsity/src/main/java/org/smartregister/command/ValidateStructureMapCommand.java
Outdated
Show resolved
Hide resolved
efsity/src/main/java/org/smartregister/command/ValidateStructureMapCommand.java
Outdated
Show resolved
Hide resolved
efsity/src/main/java/org/smartregister/command/ValidateStructureMapCommand.java
Outdated
Show resolved
Hide resolved
efsity/src/main/java/org/smartregister/command/ValidateStructureMapCommand.java
Outdated
Show resolved
Hide resolved
efsity/src/main/java/org/smartregister/command/ValidateStructureMapCommand.java
Outdated
Show resolved
Hide resolved
efsity/src/main/java/org/smartregister/command/ValidateStructureMapCommand.java
Outdated
Show resolved
Hide resolved
efsity/src/main/java/org/smartregister/processor/StructureMapProcessor.java
Show resolved
Hide resolved
Since we intend to run this via CI for the automation how do we intent to handle this case? |
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #199
Engineer Checklist
./gradlew spotlessApply
to check my code follows the project's style guide