-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add structure map generation tool to efsity #202
base: main
Are you sure you want to change the base?
Conversation
@sharon2719 @Lentumunai-Mark this is the PR that needs to be finished up to get the sm-tool integrated into efsity |
Noted @Wambere |
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
initial start. Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also add a new page under efsity/docs
for this command with more information especially on the xls configuration file, what that should look like and an example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some notes so far, didn't get to review everything
efsity/src/main/java/org/smartregister/command/GenerateStructureMapCommand.java
Show resolved
Hide resolved
efsity/src/main/java/org/smartregister/command/GenerateStructureMapCommand.java
Show resolved
Hide resolved
efsity/src/main/kotlin/org/smartregister/structuremaptool/GenerateStructureMapService.kt
Show resolved
Hide resolved
efsity/src/main/kotlin/org/smartregister/structuremaptool/GenerateStructureMapService.kt
Show resolved
Hide resolved
Could we also use version catalogs for these entries? - fhir-tooling/efsity/build.gradle.kts Lines 90 to 96 in 322fce5
|
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #[issue number] or Closes #[issue number]
Engineer Checklist
./gradlew spotlessApply
to check my code follows the project's style guide