[Error Actionability] Improve Omegaconf config error when root type is None #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu0607
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve the error message for the above scenario to indicates which field leads to exception.
If parent config is None, we can not set child column.
Example:
the error message was
Unexpected type for root: NoneType. with this PR the error message becomesUnexpected type for root: NoneType. We cannot set 'smc_tier' to 'test_hydra' when root is None. Please make sure the config value of ['checkpoint_eval', 'smc_tier'] is valid.Test Plan
Internal testing at Meta