Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListConfig.__setitem__ cannot handle slice #736

Closed
Jasha10 opened this issue Jun 1, 2021 · 0 comments
Closed

ListConfig.__setitem__ cannot handle slice #736

Jasha10 opened this issue Jun 1, 2021 · 0 comments
Assignees
@pixelb
Labels
bug Something isn't working
Milestone
OmegaConf 2.2

Comments

@Jasha10
Copy link
Collaborator

Jasha10 commented Jun 1, 2021

ListConfig.__getitem__ can take a slice as input, but ListConfig.__setitem__ fails when passed a slice:

from omegaconf import *
cfg = OmegaConf.create(["a", "b", "c", "d'"])
assert cfg[1:3] == ["b", "c"]  # succeeds
cfg[1:3] = ["x", "y"]  # fails with ConfigTypeError
@omry omry added the bug Something isn't working label Jun 2, 2021
@omry omry added this to the OmegaConf 2.2 milestone Jun 2, 2021
@Jasha10 Jasha10 self-assigned this Jul 30, 2021
@pixelb pixelb assigned pixelb and unassigned Jasha10 Nov 1, 2021
@Jasha10 Jasha10 assigned Jasha10 and unassigned Jasha10 Nov 11, 2021
pixelb added a commit to pixelb/omegaconf that referenced this issue Feb 1, 2022
@pixelb
support slice assignment in ListConfig (omry#736)
3a4f296
pixelb added a commit to pixelb/omegaconf that referenced this issue Feb 1, 2022
@pixelb
support slice assignment in ListConfig (omry#736)
c25bb9c
pixelb added a commit to pixelb/omegaconf that referenced this issue Feb 1, 2022
@pixelb
support slice assignment in ListConfig (omry#736)
ac17c59
pixelb added a commit to pixelb/omegaconf that referenced this issue Feb 1, 2022
@pixelb
support slice assignment in ListConfig (omry#736)
a07b932
pixelb added a commit to pixelb/omegaconf that referenced this issue Feb 1, 2022
@pixelb
support slice assignment in ListConfig (omry#736)
22b4fc7
pixelb added a commit to pixelb/omegaconf that referenced this issue Feb 3, 2022
@pixelb
support slice assignment in ListConfig (omry#736)
9315e24
pixelb added a commit to pixelb/omegaconf that referenced this issue Feb 3, 2022
@pixelb
support slice assignment in ListConfig (omry#736)
7d82702
pixelb added a commit to pixelb/omegaconf that referenced this issue Feb 3, 2022
@pixelb
support slice assignment in ListConfig (omry#736)
441e1c4
pixelb added a commit to pixelb/omegaconf that referenced this issue Feb 7, 2022
@pixelb
support slice assignment in ListConfig (omry#736)
16fe1cc
pixelb added a commit to pixelb/omegaconf that referenced this issue Feb 7, 2022
@pixelb
support slice assignment in ListConfig (omry#736)
882d43e
pixelb added a commit to pixelb/omegaconf that referenced this issue Feb 7, 2022
@pixelb
support slice assignment in ListConfig (omry#736)
445ac46
pixelb added a commit to pixelb/omegaconf that referenced this issue Feb 7, 2022
@pixelb
support slice assignment in ListConfig (omry#736)
786ce02
pixelb added a commit that referenced this issue Feb 7, 2022
@pixelb
support slice assignment in ListConfig (#736)
f3e5b2b
@pixelb pixelb closed this as completed Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelb pixelb

Labels
bug Something isn't working
Projects
None yet
Milestone
OmegaConf 2.2
Development

No branches or pull requests
3 participants
@pixelb @omry @Jasha10