Make key in cfg return True whenever key is an interpolation (even when its resolution fails)
#562
Assignees
Milestone
Comments
omry
pushed a commit
that referenced
this issue
Mar 3, 2021
* Interpolations are never considered to be missing anymore, even if they point to a missing node * When resolving an expression containing an interpolation pointing to a missing node, an `InterpolationToMissingValueError` exception is raised * When resolving an expression containing an interpolation pointing to a node that does not exist, an `InterpolationKeyError` exception is raised * `key in cfg` returns True whenever `key` is an interpolation, even if it cannot be resolved (including interpolations to missing nodes) * `get()` and `pop()` no longer return the default value in case of interpolation resolution failure (same thing for `OmegaConf.select()`) * If `throw_on_resolution_failure` is False, then resolving an interpolation resulting in a resolution failure always leads to the result being `None` (instead of potentially being an expression computed from `None`) Fixes #543 Fixes #561 Fixes #562 Fixes #565
odelalleau
added a commit
to odelalleau/omegaconf
that referenced
this issue
Mar 10, 2021
* Interpolations are never considered to be missing anymore, even if they point to a missing node * When resolving an expression containing an interpolation pointing to a missing node, an `InterpolationToMissingValueError` exception is raised * When resolving an expression containing an interpolation pointing to a node that does not exist, an `InterpolationKeyError` exception is raised * `key in cfg` returns True whenever `key` is an interpolation, even if it cannot be resolved (including interpolations to missing nodes) * `get()` and `pop()` no longer return the default value in case of interpolation resolution failure (same thing for `OmegaConf.select()`) * If `throw_on_resolution_failure` is False, then resolving an interpolation resulting in a resolution failure always leads to the result being `None` (instead of potentially being an expression computed from `None`) Fixes omry#543 Fixes omry#561 Fixes omry#562 Fixes omry#565
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Currently,
key in cfgcan be False ifkeyis an interpolation to a missing node (i.e., set to"???") or a node that does not exist.This can be dangerous as users may believe a key was not defined in the config while it was. This is also inconsistent with #543, which makes it so that an interpolation to a missing node isn't missing anymore.
Describe the solution you'd like
Instead, make it return True for all interpolations (regardless of whether or not they can be resolved).
Additional context
This is resolved by #545. Creating this issue to keep track of the change.
The text was updated successfully, but these errors were encountered: