-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate exclude_structured_configs; introduce SCMode enum #548
Milestone
Comments
The |
Closing as duplicate of #556 |
Jasha10
added a commit
to Jasha10/omegaconf
that referenced
this issue
Feb 23, 2021
Jasha10
added a commit
that referenced
this issue
Feb 25, 2021
* to_container: replace exclude_structured_configs with SCMode Closes #548 Co-authored-by: Omry Yadan <omry@fb.com> * Add note about `structured_config_mode` to docs * revise documentation * Update OmegaConf.to_container docstring * add news/548.api_change
odelalleau
pushed a commit
to odelalleau/omegaconf
that referenced
this issue
Mar 10, 2021
* to_container: replace exclude_structured_configs with SCMode Closes omry#548 Co-authored-by: Omry Yadan <omry@fb.com> * Add note about `structured_config_mode` to docs * revise documentation * Update OmegaConf.to_container docstring * add news/548.api_change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
exclude_structured_configs is new in 2.1 and we can still change it.
Looks like an enum can replace exclude_structured_configs and instantiate:
Originally posted by @omry in #502 (comment)
Based on the above, it is planned to deprecate the
exclude_structured_configs
argument to theOmegaConf.to_container
function. In it's place, it is proposed to add astructured_config_mode: SCMode
argument to theto_container
function's signature. This argument will determine what behavior occurs whento_container
encounters a StructuredConfig.To preserve the current default behavior, the default value will be
structured_config_mode = SCMode.DICT
.The text was updated successfully, but these errors were encountered: