Skip to content

Conversation

@JaapBosheuvel
Copy link

For the OMNT app we wanted to add the feature to log for both subscriptions. The following features are implemented to enable this feature and some small improvements to make it not required to restart the app before changes are applied:

  • first startup now contains permission check that only runs initialization after all permissions are granted (fills ui immediately)
  • added 'all subscriptions' option (set as default) for set subscriptions option
  • subscriptions can now be changed dynamically during runtime and during logging, which also immediately affects UI (no reboot required)

TODO

  • signal strength logging still compatible for only one subscription;
  • neighbour cells unidentifiable and should be sanitized with mcc/mnc of registered cell (can still be done manually due to logging is ordered e.g. for 20416 and neighbour cells enabled then following cells without mcc/mnc are logically its neighbours until we see another cell with mcc/mnc)
  • clean up version checks, a lot of evaluation on versions below minimum sdk can be removed
  • clean up permission checks, added some missing permission annotations that could be replaced with requirespermission annotations

@hajoha hajoha changed the base branch from main to rel/0.7 December 2, 2025 12:54
@hajoha
Copy link
Contributor

hajoha commented Dec 2, 2025

Hi thanks for the PR, could you please merge latest rel/0.7 into your branch? After that I will review your PR!

@hajoha hajoha added the enhancement New feature or request label Dec 2, 2025
@hajoha hajoha self-requested a review December 2, 2025 13:04
…'all subscriptions' option (set default) for set subscriptions option to log both subscription, made compatible to dynamically switch to single subscription: TODO: signal strenght logging still compatible for only one subscription; neighbour cells unidentifiable and should be sanitized with mcc/mnc like netmonster core (can still be done manually due to logging is ordered e.g. for 20416 and nieghbour cells enabled then following cells without mcc/mnc are logically its neighbours untill we see another cell with mcc/mnc
@JaapBosheuvel JaapBosheuvel force-pushed the feature/include-double-subscription-logging branch from d87b2b4 to dae77eb Compare December 2, 2025 19:09
@JaapBosheuvel
Copy link
Author

Hi I updated the PR and rebased to rel/0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants