New features #143
New features #143
Conversation
| defined( 'ABSPATH' ) || die( 'no direct access' ); | ||
|
|
||
| /** | ||
| * Omnisend Batch class. It should be used with Omnisend Client. |
| defined( 'ABSPATH' ) || die( 'no direct access' ); | ||
|
|
||
| /** | ||
| * Omnisend Batch class. It should be used with Omnisend Client. |
| } | ||
|
|
||
| if ( $this->sku !== null && strlen( $this->sku ) > 100 ) { | ||
| $error->add( 'default_image_url', 'SKU must be under 100 characters' ); |
There was a problem hiding this comment.
SKU, not default_image_url
| } | ||
|
|
||
| if ( ! empty( $this->variants ) ) { | ||
| $arr['variants'] = $this->variants; |
There was a problem hiding this comment.
shouldn't you use productVariant method to_array here? Also, product validation should validate variants and reuse productVariant validation, because I think you will be sending and creating products and variant is a child of a product and you dont want to call separate methods and deal with it
Or perhaps I am missing something here? How are you planing to use them from client?
| * | ||
| * @return void | ||
| */ | ||
| public function set_items( $items ): void { |
There was a problem hiding this comment.
How are you planing to validate items? Because they can be product, category etc and as I understand batch methods will be used to create all of these items.
How would you create a batch of products and send them via this method? Would to_array generate correct request?
No description provided.