Clean up tests #132
Merged
Clean up tests #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanhu
force-pushed
the
sh-clean-up-tests
branch
6 times, most recently
from
1dcd3cf to
39094fb
Compare
Contributor
Author
|
@dblessing @BobbyMcWho Could you review this? |
Instead of using a fixture that is difficult to maintain, generate the actual JWT and test that. Move common code into strategy_test_case.rb.
stanhu
force-pushed
the
sh-clean-up-tests
branch
from
39094fb to
cbc6de4
Compare
This was referenced Nov 21, 2022
stanhu
added a commit
to skycocker/omniauth_openid_connect
that referenced
this pull request
Nov 29, 2022
omniauth#132 refactored the test so that nonce is automatically generated.
stanhu
added a commit
that referenced
this pull request
Nov 29, 2022
#132 refactored the test so that nonce is automatically generated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a fixture that is difficult to maintain, generate the actual JWT and test that. Move common code into
strategy_test_case.rb.This is part of the effort to upstream changes in the GitLab fork: https://gitlab.com/gitlab-org/ruby/gems/gitlab-omniauth-openid-connect/-/issues/5.