Fixes a bug where the included hook isn't run. #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subclassing doesn't run the included hook of OmniAuth::Strategy on the subclass. This is causing some issues with OmniAuth.
isaacsanders
force-pushed
the
fix-including-bug
branch
from
24f3fa6 to
43c84c8
Compare
sferik
added a commit
that referenced
this pull request
Jun 22, 2015
Fixes a bug where the included hook isn't run.
|
Thanks! I’ll push out a point release shortly. |
|
Thanks!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subclassing doesn't run the included hook of OmniAuth::Strategy on the
subclass. This is causing some issues with OmniAuth.