Bring omniauth-github up-to-date

[tmilewski]

@mbleigh - Please consider this PR and update RubyGems accordingly. The current version is out-of-date by over two years and contains security vulnerabilities. Thanks!

---

This PR does the following:

Security Updates

• Uses https for the RubyGems URL to pass bundler audit

Dependencies

• Bumps omniauth to ~>1.3.2
• Bumps omniauth-oauth2 to ~> 1.4.0
• Bumps rspec to ~> 3.5

Specs

• Updates specs to RSpec 3+ syntax

Housekeeping

• Ensure similar code formatting in specs
• Bump gem version to 1.2.0

---

Closes #59
Closes #52
Closes #57

[tmilewski]

Updates per @yaodong and @boutil's issues.

[tmilewski]

Ping @mbleigh & @intridea-shared

[mbleigh]

I don't actively maintain this gem anymore. @sferik is this one of the many
you're on?

On Sun, Aug 28, 2016, 3:00 PM Tom Milewski notifications@github.com wrote:

Ping @mbleigh https://github.com/mbleigh

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#61 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAD_nFid6tC5XEg5hEXv7DYFYbnFuiBks5qkgTzgaJpZM4JebJ1
.

[tmilewski]

@mbleigh All good, I just want to make sure it gets updated so that there's no longer any security concerns through out-of-date dependencies.

As time permits, I'm happy to take over some maintenance responsibilities as well.

[tmilewski]

Ping @sferik, are you an owner?

[joegoggins]

No response in ~4 months would indicate that @sferik is not a maintainer.

@mbleigh , any chance you could widen the maintainer pool to include @tmilewski so this could get merged and released to rubygems?

[mbleigh]

@tmilewski you've been added.

[sferik]

Sorry, just seeing this now…

@tmilewski Welcome to the team!

[tmilewski]

@mbleigh @sferik Thanks guys! Going through this now!

[tmilewski]

@mbleigh:
Mind adding me to RubyGems so that I may push this out to the world? Thanks!
gem owner omniauth-github --add tmilewski@gmail.com

---

All:
In the meantime, this will work...
gem 'omniauth-github', git: 'https://github.com/intridea/omniauth-github.git', tag: '1.2.0'

[mbleigh]

@tmilewski the power is yours!

[tmilewski]

@mbleigh Perfect, thank you! It's now live!