Fix offset in comments #624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akolotov
added
the
team-august-2021
akolotov
approved these changes
Aug 16, 2021
akolotov
added a commit
that referenced
this pull request
Sep 6, 2021
This update for the `master` branch contains the changes made to address findings discovered during a security audit: * [Fix] Stricter preconditions for payInterest (#623) * [Fix] Fix offset in comments (#624) * [Fix] Use fixed lower call gas limit (#627) * [Fix] Separate XDaiForeignBridge contract with compound and GSN support (#626) * [Fix] Update GSN interface (#628) * [Fix] Block ERC20 selectors in AMB requests (#630) * [Other] Bump package and contracts interfaces version prior to 6.0.0 (#629)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function parseMessage is preceded by a comment about the offsets of the different parts within the message. It contains:
https://github.com/poanetwork/tokenbridge-contracts/blob/b3511bf0987bbfef661e28dd1a6fbe1735f90ac0/contracts/libraries/Message.sol#L18
However the correct offset is 116. The code implements it correctly.