feat(contracts/solve): gas optimized SolverNetInbox open flow #2950
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I significantly reduced gas costs for SolverNetInbox's
open()
function. This was done by storing theOnchainCrossChainOrder
struct rather than the complexResolvedCrossChainOrder
struct. Then, in any function that relies on theResolvedCrossChainOrder
, it is resolved again for these functions. The majority of the gas savings were found inopen
, but all of the other order functions saw gas reductions too. We can likely go way further than this ~20% reduction in costs, but this was what I could squeeze out without any impact to the solver. The interface remains entirely unchanged.Here are gas reports for the impacted functions:
Preoptimizations:
Postoptimizations:
issue: #2917