Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(octane/evmengine): reject payloads with deposits #2528

Merged
merged 1 commit into from
Nov 22, 2024
Merged

fix(octane/evmengine): reject payloads with deposits #2528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(octane/evmengine): reject payloads with deposits
  • Loading branch information
@corverroos
corverroos committed Nov 21, 2024
commit fb94e1a44f70fefa42a34ba0f79367d3e7c1d0db
5 changes: 5 additions & 0 deletions octane/evmengine/keeper/keeper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,11 @@ func (k *Keeper) parseAndVerifyProposedPayload(ctx context.Context, msg *types.M
return engine.ExecutableData{}, errors.New("withdrawals not allowed in payload")
}

// Ensure no deposits are included in the payload.
if len(payload.Deposits) > 0 {
return engine.ExecutableData{}, errors.New("deposits not allowed in payload")
}

// Ensure fee recipient using provider
if err := k.feeRecProvider.VerifyFeeRecipient(payload.FeeRecipient); err != nil {
return engine.ExecutableData{}, errors.Wrap(err, "verify proposed fee recipient")
Expand Down
Loading