fix(halo/app): fix ready command #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
approved these changes
Oct 18, 2024
halo/cmd/ready.go
Outdated
| @@ -16,7 +16,7 @@ type readyConfig struct { | |||
|
|
|||
| func defaultReadyConfig() readyConfig { | |||
| return readyConfig{ | |||
| MonitoringURL: "http://localhost:26660", | |||
| MonitoringURL: "http://localhost:26660/ready", | |||
There was a problem hiding this comment.
I'd argue that MonitoringURL should only be the base host and port of the monitoring API to query. The ready command should add the path it wants to query to in that base URL
There was a problem hiding this comment.
Agreed, I had the same first intuition, but then remembered the "remote node" discussion and was not sure anymore. Will make it a non-configurable part of the URL.
chmllr
force-pushed
the
chmllr/ready-bugfix
branch
from
128dc84
to
4bc3b82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
readycommand that is using the wrong URL for readiness check.issue: none