ci(e2e): populate p2p with advertised addrs #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corverroos
requested review from
arajasek,
kevinhalliday and
brid
as code owners
arajasek
approved these changes
Jul 23, 2024
corverroos
added a commit
that referenced
this pull request
Jul 24, 2024
When attempting to join omega using `omni operator init-nodes` and the local node fetches peer addresses from the bootstrapped peers, debug logs show that private IPs are returned, this causes P2P networking to fail. This attempt to address the problem by using "advertised" IPs consistently (not only in advertised IP context). This means that our internal nodes will also connect to seed/fullnodes using their external IPs. When asked for peers, they would then hopefully return those external IPs and not internal IPs like previously. issue: none
corverroos
added a commit
that referenced
this pull request
Jul 24, 2024
Cherry picks #1560 from `main` to `release/v0.2`. This is required to improve joining omega. issue: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to join omega using
omni operator init-nodesand the local node fetches peer addresses from the bootstrapped peers, debug logs show that private IPs are returned, this causes P2P networking to fail.This attempt to address the problem by using "advertised" IPs consistently (not only in advertised IP context).
This means that our internal nodes will also connect to seed/fullnodes using their external IPs.
When asked for peers, they would then hopefully return those external IPs and not internal IPs like previously.
issue: none