Migrate codebase to use cli/v3 #468
Merged
+14
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the codebase from urfave/cli v1 to v3, updating imports, flag definitions, and CLI method signatures to match the new API.
- Switch imports and dependencies to use
github.com/urfave/cli/v3 - Update flag declarations to pointer-based
&cli.StringFlag{}and CLI command signatures - Adjust
appinstantiation andActionhandlers to align with v3 API
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| service/init.go | Updated CLI import, flag definitions, and method signatures to v3 |
| go.mod | Replaced github.com/urfave/cli v1 with github.com/urfave/cli/v3 |
| amf.go | Switched to cli/v3: application initialization and action signature |
Signed-off-by: Arrobo, Gabriel <gabriel.arrobo@intel.com>
gatici
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.