Refactor (II) #12
Merged
Refactor (II) #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Temporarily closing as it will need to be rebased on top of #14 |
Always merge
- Create Github instances dictionary and get_github() access method
Add string argument to get_remote_info method
Member
|
a test! |
Member
|
Looks fine. Merging and we can see how it fairs in the testing today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts decoupling the objects used when merging PRs
get_github()method to avoid recreating Github instance in submodulesRetested on various repositoris, containing or not submodules
Next step in refactoring will be the separation of GitRepository and GithubRepository.