FS path changes arising from post-PR669 discussion with Josh #751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The decision was to maintain a top-level user directory which has special permission handling. The directory (of the form `%name%_%id%`) will be placed in the "user" group so that it is visible from all queries. NB: This does not yet fix the rest of the code that assumes writing to the top directory is permissible!
Member
Author
|
I don't like that bit of debugging I mentioned that catches that exception. Will close this PR and test some more in case that debug statement is catching something still triggerable that I needed to come back to and fix, and open a PR once I've checked things are okay. Anyone else wanting to test too can still merge my branch locally. |
Member
Author
|
Superseded by #756 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something of a mixed bag and requires ome/bioformats#374 to work. Major themes are:
ImportLibraryfixes paths (so import from Windows to Unix is improved)