-
Notifications
You must be signed in to change notification settings - Fork 103
Minor comment and string fixes. #721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Documentation update in ome/omero-documentation#245 |
|
@mtbc: all of these were in your fs-path PR? |
|
No, I'll have to rebase this to develop (but half of it should vanish in the process). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't really fall under the description of this commit/PR. Probably fine, but do shoot for the principle of least surprise where possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I forgot I'd noticed this; adjusted description accordingly.
|
I will use one PR only to fix the UTF-8 stuf. |
|
@jburel: You want me to break this PR into two, one with UTF-8 things, one with the other things? |
|
Though we could wait for this to be rebased and just cherry pick 08c0721 |
|
What's the plan? Move the non-utf8 stuff into another PR? |
|
Will do. |
Small tweaks, partly caused by comments on PRs #669, #690.
Set Java source files to be UTF-8.
Also correct resource leakage in
TempFileManager.