Skip to content

Replace accented character in unknown charset with unicode equivalent (#10251) #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
manics wants to merge 3 commits into from
Closed

Replace accented character in unknown charset with unicode equivalent (#10251) #690

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08c0721
Replace accented character in unknown charset with unicode equivalent…
manics Jan 31, 2013
4af0f14
Use \u escapes instead of utf8
manics Feb 4, 2013
61f61b8
Revert "Use \u escapes instead of utf8"
manics Feb 5, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/blitz/test/ome/services/blitz/test/utests/ManagedRepositoryITest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,9 +402,9 @@ public void testExpandTemplateEscape3() {

@Test
public void testExpandTemplateUnknown() {
String expected = "%bj�rk%";
String expected = "%björk%";
newEventContext();
String actual = this.tmri.expandTemplate("%bj�rk%", curr);
String actual = this.tmri.expandTemplate("%björk%", curr);
Copy link
Member

@mtbc mtbc Feb 4, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\u00F6 is also an option

Copy link
Member Author

@manics manics Feb 4, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we're consistent everywhere.

Copy link
Member

@mtbc mtbc Feb 4, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, given how easy it seems to be to mess up encodings in source and how different viewing applications seem to cope differently (at least on the Mac), maybe we should be using escaped codepoints everywhere, yes. What do you think? I could file a ticket about fixing the other instances and fix the others I notice in the meantime. (I had already fixed mine in mtbc@7b77a74 -- I assume there's some convenient tool into which one can paste the strings to get their escaped equivalents.)

Assert.assertEquals(expected, actual);
}

Expand Down