Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use only pytest < 3 #4886

Merged
merged 3 commits into from
Oct 31, 2016
Merged

use only pytest < 3 #4886

merged 3 commits into from
Oct 31, 2016

Conversation

atarkowska
Copy link
Member

@atarkowska atarkowska commented Oct 10, 2016

What this PR does

try to fix pytest version

Testing this PR

go to:

and check which version is used when tests are run, it is listed in:

05:24:34 ============================= test session starts ==============================
05:24:34 platform linux2 -- Python 2.7.5, pytest-3.0.3, py-1.4.31, pluggy-0.4.0 ...

Related reading

#4826

LIMITATIONS:

for some reason merge build has pytest-2.8.1 installed, that is not very clear to me where is that exactly. This PR run on merge didn't change anything, see #4886 (comment)

@atarkowska atarkowska closed this Oct 10, 2016
@atarkowska atarkowska reopened this Oct 10, 2016
@joshmoore
Copy link
Member

Is pytest causing any other issues? If none, cfbfac9 is probably we should be doing anyway in our tests. i.e. this could be our fault not pytests.

@atarkowska
Copy link
Member Author

atarkowska commented Oct 11, 2016

do you want me to drop pytest cap and cherry-pick POLICY_FIXTURES to try out?

@atarkowska
Copy link
Member Author

atarkowska commented Oct 11, 2016

I also don't understand why merge integration shows:

03:44:45 ============================= test session starts ==============================
03:44:45 platform linux2 -- Python 2.7.5, pytest-2.8.1, py-1.4.30, pluggy-0.3.1 -- /opt/hudson

virtualenv has no pytests installed

@jburel
Copy link
Member

jburel commented Oct 11, 2016

This was the comment on the initial PR
#4826 (comment)
Why is it an issue now?

@joshmoore
Copy link
Member

I don't think pytest-dev/pytest#1908 was enough. It only made it possible to accept str or unicode, but here we're passing in non-string arguments. They need to be wrapped as in cfbfac9

@jburel
Copy link
Member

jburel commented Oct 11, 2016

@joshmoore thanks

@atarkowska
Copy link
Member Author

#4853 cherry-picked

@atarkowska
Copy link
Member Author

--rebased-to #4894

@joshmoore
Copy link
Member

Filed a card to remember to uncap pytest: https://trello.com/c/TcfoKhbw/723-uncap-pytest . Merging.

@joshmoore joshmoore merged commit fa72559 into ome:develop Oct 31, 2016
@joshmoore joshmoore deleted the pytest_fix branch October 31, 2016 16:37
@jburel jburel added this to the 5.3.0 milestone Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants