-
Notifications
You must be signed in to change notification settings - Fork 103
Ome tiff export #459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ome tiff export #459
Conversation
Also moved the 'Archived Files' download button into the same dropdown menu, and added a JPEG option (same as Insight).
NB: This requires changes to the Batch Image Export script which uses the new namespace when creating OME-TIFF files.
Possible RFE: @gusferguson
|
|
RFE logged. |
|
Presumably still waiting for ome/omero-scripts#10 ? |
|
@manics I'm not sure what you mean? The functionality of this PR relies on ome/omero-scripts#10 but can still be merged without it. For dev_4_4, the testing of both was handled by the main repo PR, then the scripts PR was merged shortly afterwards. |
|
@will-moore I thought checking for an existing OME-TIFF (and overwriting) was part of this PR? If so it doesn't work, multiple OME-TIFFs are created and attached, and no warning is given. |
|
@manics Ooops, my mistake. ome/omero-scripts#10 is against master, not develop. Closed and re-opened as ome/omero-scripts#11. Hope that works. Cheers. |
|
Works as expected, checks for existing OME-TIFF and suggests download, overwrites if a new version is created. A couple of small points: The annotations list isn't dynamically updated with the OME-TIFF (reload needed), and in IE8 it doesn't always warn about an existing OME-TIFF (I think it might be some strange caching behaviour). Both these are also present in dev_4_4 so can be left for later. Ready to merge. |
|
Thanks, @manics . @will-moore, I've opened https://trac.openmicroscopy.org.uk/ome/ticket/9913 for a documentation of the new setup. Let me know if I've just overlooked it. I've bumped the SHA1 on the scripts submodule for develop, and am merging. |
This is in dev_4_4 as #417. Now for develop. NB: requires ome/omero-scripts#10.