Skip to content

Conversation

@will-moore
Copy link
Member

This is in dev_4_4 as #417. Now for develop. NB: requires ome/omero-scripts#10.

@will-moore will-moore mentioned this pull request Nov 2, 2012
@jburel
Copy link
Member

jburel commented Nov 5, 2012

@will-moore:

  • I created an OME-TIFF, the file is successfully created and linked to the image.
  • Refresh image, select Export as ome-tiff, the Download option is not available. It works on howe not gretzky

Possible RFE: @gusferguson

  • Long file could be truncated in activities windows
  • I also have in the Activities list, action made days ago. That will need to be reviewed/synch'ed between clients.

@gusferguson
Copy link

RFE logged.

@manics
Copy link
Member

manics commented Nov 6, 2012

Presumably still waiting for ome/omero-scripts#10 ?

@will-moore
Copy link
Member Author

@manics I'm not sure what you mean? The functionality of this PR relies on ome/omero-scripts#10 but can still be merged without it. For dev_4_4, the testing of both was handled by the main repo PR, then the scripts PR was merged shortly afterwards.

@manics
Copy link
Member

manics commented Nov 6, 2012

@will-moore I thought checking for an existing OME-TIFF (and overwriting) was part of this PR? If so it doesn't work, multiple OME-TIFFs are created and attached, and no warning is given.

@will-moore
Copy link
Member Author

@manics Ooops, my mistake. ome/omero-scripts#10 is against master, not develop. Closed and re-opened as ome/omero-scripts#11. Hope that works. Cheers.

@will-moore will-moore mentioned this pull request Nov 12, 2012
@manics
Copy link
Member

manics commented Nov 12, 2012

Works as expected, checks for existing OME-TIFF and suggests download, overwrites if a new version is created. A couple of small points: The annotations list isn't dynamically updated with the OME-TIFF (reload needed), and in IE8 it doesn't always warn about an existing OME-TIFF (I think it might be some strange caching behaviour). Both these are also present in dev_4_4 so can be left for later.

Ready to merge.

@joshmoore
Copy link
Member

Thanks, @manics . @will-moore, I've opened https://trac.openmicroscopy.org.uk/ome/ticket/9913 for a documentation of the new setup. Let me know if I've just overlooked it.

I've bumped the SHA1 on the scripts submodule for develop, and am merging.

joshmoore added a commit that referenced this pull request Nov 15, 2012
@joshmoore joshmoore merged commit 487bf0f into ome:develop Nov 15, 2012
@sbesson sbesson modified the milestones: 5.0.0, 5.0.0-alpha1 Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants