Skip to content

Conversation

@will-moore
Copy link
Member

This is in dev_4_4 as #1002, now for develop

@atarkowska
Copy link
Member

The output of the script doesn't look the same FirefoxScreenSnapz004
user-6 on gretzky

@joshmoore
Copy link
Member

@will-moore: did something else change to cause the difference?

@will-moore
Copy link
Member Author

Is this PR in develop now? ome/omero-scripts#29
It looks like this is being run with the 'old' Thumbnail Figure script.
E.g. those timestamp strings at the top have been removed now etc.

@will-moore
Copy link
Member Author

Just tried this myself and it worked fine:

screen shot 2013-05-02 at 09 22 27

@pwalczysko
Copy link
Member

Tried to emulate Ola's workflow as much as possible.
First try (looks as expected):

screen shot 2013-05-02 at 17 44 25

Second try (looks as expected):
screen shot 2013-05-02 at 17 48 41

Third try (using Firefox - works as expected):
screen shot 2013-05-02 at 17 56 59

Fourth try was with different tag settings, (d1, d2, d3 as main categories and OK, strange, de as subcategories). Also worked as expected.

@pwalczysko
Copy link
Member

BUG: The resulting image is attached in unexpected place. Use Firefox.

  • Select all the ten images in the dataset (see screenshot above, user-4 on Gretzky) -> do not select the dataset
  • Start the Thumbnail Figure script
  • Change the default output to .png or leave the default as .jpeg - the result is the same
  • start the script
  • the resulting .png will be attached only to the image nr. 6 -> no reason for this, not expected,
    screen shot 2013-05-02 at 18 29 05

@will-moore
Copy link
Member Author

@pwalczysko OK, I see that Insight always attaches to the Dataset of the first image (if images chosen) or simply to the first Dataset if Datasets are chosen.

@will-moore
Copy link
Member Author

@pwalczysko That should fix the attachment issue - too late for this morning's build, but if we build again later it'll be in.

@pwalczysko
Copy link
Member

Sorry, did not manage the local build with this one. Will try to check tomorrow, when this is in the merge.

@pwalczysko
Copy link
Member

Works as expected.

joshmoore added a commit that referenced this pull request May 16, 2013
@joshmoore joshmoore merged commit 6e081bf into ome:develop May 16, 2013
@joshmoore joshmoore deleted the thumbnail_figure_develop branch May 16, 2013 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants