Skip to content

Developer docs tidy 3 #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jburel merged 6 commits into from
Feb 18, 2013
Merged

Developer docs tidy 3 #254

jburel merged 6 commits into from
Feb 18, 2013

Conversation

@hflynn
Copy link
Contributor

@hflynn hflynn commented Feb 15, 2013

This clears up the remaining nitpicks in the developer documentation which were spotted on rebased PRs (#247 and #252) by Mark and JM.

@hflynn
Copy link
Contributor Author

hflynn commented Feb 15, 2013

I suggest @mtbc has the delight of reviewing this, because if he spots a bunch of stuff once it is rebased again, I maybe forced to get annoyed ;)

@hflynn
Copy link
Contributor Author

hflynn commented Feb 15, 2013

In ImportLibrary.txt - "ImportConfig.java" trails off, is this because it is referring to the ImportEvent.java below or should this sentence finish with something?

@joshmoore
Copy link
Member

joshmoore commented Feb 15, 2013

"an extensible mechanism for storing ... properties used during import"?

@mtbc
Copy link
Member

mtbc commented Feb 18, 2013

Yes, I'll be happy to review ones against dev_4_4. (-:

mtbc
mtbc reviewed Feb 18, 2013
View reviewed changes
developers/Model.txt Outdated
Copy link
Member

@mtbc mtbc Feb 18, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"straightforward" is all one word, I think, at least for this meaning?

@mtbc
Copy link
Member

mtbc commented Feb 18, 2013

I saw no showstoppers, but I provided some thoughts in case, in @hflynn's judgment, a further commit to this PR is warranted before merging.

@hflynn
Copy link
Contributor Author

hflynn commented Feb 18, 2013

I'm done with this unless anyone finds anything else this afternoon.

@hflynn
Copy link
Contributor Author

hflynn commented Feb 18, 2013

Typo in my commit message is NOT in docs BTW!

@mtbc
Copy link
Member

mtbc commented Feb 18, 2013

Looks good to merge.

jburel added a commit that referenced this pull request Feb 18, 2013
@jburel
Merge pull request #254 from hflynn/dev_fix3
c42e953 
Developer docs tidy 3
@jburel jburel merged commit c42e953 into ome:dev_4_4 Feb 18, 2013
@hflynn hflynn mentioned this pull request Feb 19, 2013
Merged
@hflynn hflynn deleted the dev_fix3 branch February 19, 2013 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dev_4_4

Projects

None yet

Milestone

4.4.7

Development

Successfully merging this pull request may close these issues.

4 participants

@hflynn @joshmoore @mtbc @jburel