Skip to content

Conversation

@hflynn
Copy link
Contributor

@hflynn hflynn commented Feb 7, 2013

To fix typos and self-linkage etc left over from move from Trac wiki.
Also addressing https://trac.openmicroscopy.org.uk/ome/ticket/10213

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the leading whitespace in this link and the following ones?

@sbesson
Copy link
Member

sbesson commented Feb 7, 2013

Apart from minor fixes/suggestions above, I think we should adopt a standard for 2 items:

  • generic method names, e.g. Class.get...(), Class.get..., Class.get*, Class.getxxx(), etc.
  • non-OMERO commands, e.g. git config or :command:git config``

@hflynn
Copy link
Contributor Author

hflynn commented Feb 7, 2013

Fixes done.
Re: standards, I prefer Class.get* although I'm happy to use xxx for replacing numbers (this is used in user docs). I'm trying to use :command: more but I don't always spot where it is applicable as yet and to be honest, I prefer the highlighting the double quotation marks give.

@sbesson
Copy link
Member

sbesson commented Feb 8, 2013

Added a couple of extra nitpicky details that can be addressed in another PR if we want this PR to be included in the pointer of the open microscopy v.4.4.6 tag.
I will work on unifying the :command: and :omerocmd: styles in a separate PR.

@jburel
Copy link
Member

jburel commented Feb 11, 2013

@sbesson, @hflynn: Merging this PR. I have linked PR and the ticket i.e. https://trac.openmicroscopy.org.uk/ome/ticket/10213
Minor points noticed by @sbesson to be done in a separate PR.

jburel added a commit that referenced this pull request Feb 11, 2013
@jburel jburel merged commit 2759d65 into ome:dev_4_4 Feb 11, 2013
@hflynn hflynn deleted the 10213-edits branch February 11, 2013 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants