Allow slices to be deleted from a virtual stack#4437
Open
melissalinkert wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4004.
To test in ImageJ, open any file with multiple planes using
Plugins > Bio-Formats > Bio-Formats ImporterwithUse virtual stackchecked. Move the slider to any plane, and selectImage > Stacks > Delete Slice. The stack size should decrease appropriately, and moving the slider through all planes should work as expected without error. Deleting additional slices from the same stack should also work.As an initial test, it might be worth using one of the datasets in https://downloads.openmicroscopy.org/images/OME-TIFF/2016-06/bioformats-artificial/, as those have plane indexes visible on each image, so it should be easy to see if the correct planes are being read after deletion.