Skip to content

Conversation

@qidane
Copy link
Contributor

@qidane qidane commented Nov 21, 2012

No description provided.

@sbesson
Copy link
Member

sbesson commented Nov 22, 2012

Same test as #221. Ran Print to PDF (Open as PDF in Preview) under OSX.
Ready to merge.

@jburel
Copy link
Member

jburel commented Nov 22, 2012

@qidane: do you want the PR to be tested on other platform?

@joshmoore
Copy link
Member

A Window browser, perhaps? @pwalczysko could you do that. If so, we may want to merge this anyway, since we'll need to open minimally 3 other PRs to get dev_4_4 & develop updated for OMERO and BF.

@pwalczysko
Copy link
Member

Tried on IE8, WinXP run on VB. Print to pdf. The left margin was too large (already in Print Preview), so that the text on the right-hand side was falling out of the window (very very hard to adjust manually pre-print - I actually gave it up - never got the text into the window).
Firefox (Win XP) was okay (in this respect).
Google Chrome (Win XP) was okay (in this respect).
For comparison ran the same on Safari OSX 10.8. - result looks similar to Firefox and Google Chrome, although I am not sure whether the header is really hidden (can switch it off and on in IE8).
Check squig team/screenshots/VB pdf prints/....
Tested web page
https://www.openmicroscopy.org/site/support/bio-formats-develop/

Printed out also the pages under the abovementioned page, all the same results in IE8.
All on squig, team/screenshots/VB pdf prints/...

@joshmoore
Copy link
Member

@pwalczysko, can you open a ticket with that information for Andrew. I'll merge this and when Andrew returns we can address more of the CSS/printing issues. Thanks.

joshmoore added a commit that referenced this pull request Nov 26, 2012
Hiding header and menu when printing
@joshmoore joshmoore merged commit a663b63 into ome:develop Nov 26, 2012
@pwalczysko
Copy link
Member

joshmoore: Ticket #9955 created with the printing issues in IE8 mentioned above.

hflynn pushed a commit to hflynn/bioformats that referenced this pull request Oct 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants