Fixes for pyramid TIFF reading #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot always assume that T is 1; in particular, it should be 3 for pyramids generated from single RGB images. See #9871.
This multiplication was introduced in 0599079, and as far as I can tell that was always a bug. It works fine if at least one of the following is true: * only one tile * only one channel * non-planar channels However, if we have a multi-channel, multi-tile image with planar channels then SizeC times too many tiles are read into the image buffer. See also github.com/ome/pull/211.
|
Some failures testing with test_images_good/pyramid. Thumbnail size issues are expected. Not sure if the SizeT issues are actual errors, or just outdated configuration. |
|
With the test configuration updated, the thumbsize errors are removed: |
Member
Author
|
Fixed in configuration (but note that BIOFORMATS-test_images_good will now fail until this PR is merged). |
Member
Author
|
Merging this on Wednesday morning if no other objections. |
Member
|
Similarly getting this now so that the tests will have it for the morning. |
joshmoore
added a commit
that referenced
this pull request
Nov 27, 2012
Fixes for pyramid TIFF reading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #211, rebased onto develop.