Remove legacy ome-editor and ome-notes

[ghost]

This removes all of components/legacy and ome-java-deprecated.jar and updates the build and deps scripts accordingly.

[ghost]

In case anyone wishes to keep the legacy code for whatever reason, I've prepared a filtered copy of the repo. It's currently here:

https://github.com/rleigh-dundee/bioformats/tree/bioformats-legacy

But can be put into an independent bioformats-legacy repo if it's needed to be preserved.

[melissalinkert]

Sorry, I'm a little unclear as to why all of this actually needs to be removed right now. If this is to facilitate Debian packaging, is it not sufficient to use individual jar-* targets instead of ant jars (so you could just choose not to build the legacy components)?

[ghost]

On 07/08/2012 18:40, Melissa Linkert wrote:

Sorry, I'm a little unclear as to why all of this actually needs to be
removed right now. If this is to facilitate Debian packaging, is it not
sufficient to use individual jar-* targets instead of |ant jars| (so you
could just choose not to build the legacy components)?

It would certainly be possible to call the individual targets. However,
isn't this long obsolete OME server stuff that's no longer actually used
at all?

Regards,
Roger

The University of Dundee is a registered Scottish Charity, No: SC015096

[melissalinkert]

Most of this actually has nothing to do with OME server. It's definitely not actively maintained, but I have no idea who (if anyone) is using it - just because OMERO doesn't need it doesn't mean that no one else does.

My personal feeling is that if we're going to remove this, it should be as part of a major release, but if the majority rule is to get rid of it now that's fine (I'm not dearly attached to the legacy component code, I just don't want to hurt those who might still be using it). I'll mention this PR in email tonight, and hopefully anyone else who has a strong feeling can chime in.

[joshmoore]

I wouldn't suggest dropping these for a point release, though it may make sense to remove them from the main target. I.e. jars could skip them and anyone who wanted them could call that target manually.

[melissalinkert]

This branch no longer merges cleanly.

[ghost]

This is now mergeable into develop. Note that "ant test" and "mvn" currently show a test failure, but this is also present on current develop:

[ERROR] /Users/rleigh/bioformats3/components/scifio/test/loci/formats/utests/FormatTools.java:[53,7] class ServiceFactoryTest is public, should be declared in a file named ServiceFactoryTest.java

I'm not an ant/maven expert, and while these all work as far as I've tested, the changes to the build logic in removing the legacy code definitely could use some checking over.

[sbesson]

OMERO-merge-develop jobs #39, #40 & #41 failed when including this PR. When specifically excluding this PR, build #42 was successful. Labelled as conflicting.

First compile error in the console output is:

Compiling 26 source files to /home/omero/slave/workspace/OMERO-merge-develop/src/components/romio/target/classes
/home/omero/slave/workspace/OMERO-merge-develop/src/components/romio/src/ome/io/bioformats/BfPixelsWrapper.java:18: package loci.common does not exist
import loci.common.DataTools;

[melissalinkert]

Why is this being removed?

[ghost]

OK. I removed it because of the OMENotesService references, but I'll add it back.

[joshmoore]

@rleigh-dundee ping

[ghost]

Updated to restore the documentation, but removed references to deleted code.

[joshmoore]

@rleigh-dundee, this commit is still grayed out ("cannot be merged")

[joshmoore]

Roger, this is still failing the build. See build 50 of OMERO-merge-develop. Marking as needs-fixes.

[ghost]

Build issues with OMERO are now fixed.