This repository has been archived by the owner on Jan 8, 2021. It is now read-only.
Change key #5
Merged
Change key #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jburel
force-pushed
the
change-key-folder-ansible22
branch
from
ed19558
to
cd77ae1
Compare
Files did not have correct owner preventing jobs to be executed
So playbook does not need to be run twice
The specification has changed, the user is read from the .gitconfig file directly
Merged
joshmoore
reviewed
Nov 20, 2017
| @@ -9,7 +9,7 @@ Role Variables | |||
|
|
|||
| All variables are optional, see `defaults/main.yml` for the full list | |||
|
|
|||
| - `snoopy_dir_path`: path to ssh keys and gitconfig like `/path/to/snoopy_keys`. See https://github.com/openmicroscopy/devspace/blob/master/README.md for more details. | |||
| - `configuration_dir_path`: path to SSH and Git configuration files. See https://github.com/openmicroscopy/devspace/blob/master/README.md for more details. | |||
There was a problem hiding this comment.
In follow-ups, would be good if this could be removed or prefixed with devspace_
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove the usage of the snoopy key
Discussed with @sbesson:
we decided to replace
snoopy_dir_pathbyconfiguration_dir_pathsince we did not want ref to "snoopy"This change is not backward compatible