Fix Web workflow engine compatibility - #5
Draft
FengHuoLinShan wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exec.agent.ctx.workflowEnginetools, so Web can use each preset's isolated engine without mounting a second host engineRoot cause
The plugin still injected the removed
workflowsservice and calledctx.workflows.start(). Current DSH exposesworkflowEngine, while the Web composition deliberately mounts that engine inside each Agent preset rather than on the host. The host-level plugin therefore remained pending during startup.Impact
Web profiles now activate the plugin successfully. Standard/code presets route runs through their own workflow engine; presets without that capability fail with an explicit error.
Validation
pnpm run typecheckpnpm run buildnode --test(6 passed)git diff --checkdsh web --port 0startup with the packaged plugindeep_researchregistration and Agent-scoped workflow routing