Repository navigation
Add surface-snapdragon-addresses for Snapdragon Surface Wi-Fi and Bluetooth addresses - #972
Open
turbineBMW wants to merge 1 commit into
Open
turbineBMW wants to merge 1 commit into
turbineBMW wants to merge 1 commit into
Conversation
…etooth addresses The Surface Pro 11 and Surface Laptop 8 keep one base address in the MacAddressEmulationAddress UEFI variable and lay the others out the same way, as Windows' registry shows: Wi-Fi is the variable minus two, Bluetooth minus one, and the variable itself is the Surface Dock's Ethernet. ath12k reports a per-boot placeholder as the Wi-Fi permanent address, and the WCN7850 Bluetooth controller stays unconfigured until it is given a public address. A udev rule sets each ath12k Wi-Fi interface's address while it is added, before NetworkManager takes it, and a per-controller service sets the Bluetooth public address through btmgmt. Both act only when the DMI system vendor is Microsoft Corporation and the variable exists, so they do not depend on the Surface Laptop 8's device tree compatible, which is still changing. This moves the address handling out of surface-pro-11-support so both machines can use it. Validated with the package's test.sh, run as CI runs it, and a makepkg build. The Wi-Fi script passes its vendor and variable checks on a Surface Pro 11; the address logic is the one validated there in surface-pro-11-support. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
8 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Surface Pro 11 and the Surface Laptop 8 keep one base address in the
MacAddressEmulationAddressUEFI variable and lay the others out the same way around it, as Windows' registry shows: Wi-Fi is the variable minus two, Bluetooth minus one, and the variable itself is the Surface Dock's Ethernet. On Linux, ath12k reports a per-boot00:03:7fplaceholder as the Wi-Fi address, and the WCN7850 Bluetooth controller stays unconfigured until it is given a public address.This package was split out of surface-pro-11-support (#825) so both machines can use it:
ath12k_pciorath12k_wifi7_pci) to the variable minus two while it is added, before NetworkManager takes it.surface-bluetooth-address@<hci>.servicefor eachhci_uart_qcacontroller, which sets the variable minus one throughbtmgmt.Microsoft Corporationand the variable exists. They do not check the device tree, so the Surface Laptop 8's compatible (microsoft,surface-laptop8vsmicrosoft,surface-laptop-8-13in) doesn't matter.SURFACE_WIFI_ADDRESSin/etc/surface-wifi-address.conf,SURFACE_BLUETOOTH_PUBLIC_ADDRESSin/etc/surface-bluetooth-address.conf.aarch64 only, in the
omarchy-platform-qualcommgroup, edge channel.Tested on a Surface Pro 11, installed with the matching surface-pro-11-support from #825: after a reboot the Bluetooth controller came up with its public address (variable − 1,
…:AB:84), and the Wi-Fi script loggedSet wlan0 address to …:AB:83 from the firmware address variable minus twowhile udev added the interface.test.shpasses as CI runs it, and covers other vendors, a missing variable, a missing efivarfs, an interface that is already up, the override file and a failed address change. Not yet run on a Surface Laptop 8.#825 now depends on this package, so this one needs to land first or in the same publish.