-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: streamline the build and test process #51
Draft
bassco
wants to merge
78
commits into
master
Choose a base branch
from
improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add renovate.json * chore: configure renovate settings * tests: fix musl version --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Andrew Basson <andrew.basson@gmail.com>
* fix(deps): update rust crate chrono to 0.4.31 * fix(sec): removed chrono because of security advisor Signed-off-by: Gabriel Melillo <gabriel@melillo.me> * ci(deps): enable cache and fix dockerfile * build(ci): install posix compliant tar * build(ci): combine dependency install steps * chore: update cargo deps from default branch * ci: disable releases during maintenance tasks --------- Signed-off-by: Gabriel Melillo <gabriel@melillo.me> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Gabriel Melillo <gabriel@melillo.me> Co-authored-by: Andrew Basson <andrew.basson@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Bumps [num-bigint](https://github.com/rust-num/num-bigint) from 0.4.2 to 0.4.3. - [Release notes](https://github.com/rust-num/num-bigint/releases) - [Changelog](https://github.com/rust-num/num-bigint/blob/master/RELEASES.md) - [Commits](rust-num/num-bigint@num-bigint-0.4.2...num-bigint-0.4.3) --- updated-dependencies: - dependency-name: num-bigint dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [regex](https://github.com/rust-lang/regex) from 1.5.4 to 1.5.6. - [Release notes](https://github.com/rust-lang/regex/releases) - [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md) - [Commits](rust-lang/regex@1.5.4...1.5.6) --- updated-dependencies: - dependency-name: regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix(deps): update rust crate config to 0.13.3 * fix(deps): update config to 0.13.3 Signed-off-by: Gabriel Melillo <gabriel@melillo.me> --------- Signed-off-by: Gabriel Melillo <gabriel@melillo.me> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Gabriel Melillo <gabriel@melillo.me>
* fix(deps): update rust crate hyper to 0.14.27 * ci(tests): add openssl to test workflow * fix(deps): upgrade many deps and fixed code errors --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Andrew Basson <andrew.basson@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This reverts commit c50016a.
* master: chore: release-drafter be explicit with default branch name chore: release-drafter use default branch for comparison [skip-changelog] chore: release-drafter template add comparison [skip-changelog] ci(docs): update release previewer template ci(docs): add release previewer (#52)
* cargo install cargo-criterion * cargo install cargo-deny * added tokio as a dependency for the benchmarks to compile * downgraded serde and serde_derive to 1.0.190 * added benchmark script to test different features * added banchmarking notes * initialised cargo deny and added deny.toml to repo * cargo deny needs to be added to the renovate job to stop bad version bumps from creating duplicate versions and to also start the process of license checking. Additionally, cargo deny can be used for advisery alerting * fixed some code paths that were not used when using the `awc_client` feature. * added dali-bench.sh script to enable the compiling and testing of the different http servers: the default hyper_client vs awc_client. * added the first baseline test results
* Cargo features are additive in nature and default features are included when specifying additional features. There is no ability to remove a default. Our old logic exposed this bug when we tried to compile with the `awc_client` feature. We had feature `hyper_client` as the default to make it easy to build without specifying which http server implementation to use; which inadvertently set both features to enabled, when we choose the alternative, `awc_client`. When choosing feature = `awc_client`; `hyper_client` is also present, as it is the default. Therefore, we evaluate the not `awc_client` feature to enable the default behaviour. * add benchmark reports showing awc_client is superior to hyper_client * benchmark script now takes a features parameter * benchmark script opens browser when completed
* master: fix(deps): update rust crate env_logger to 0.10.1 fix(deps): update serde monorepo to 1.0.192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some of the issues, and more, raised in #11
This is the error we recevied when we tried to
cargo build --features aws_client
This is caused because cargo treats features as additive. Because hyper_client was set as a default; it was also set when we tried the build the awc_client feature. The test to see which feature to enable had to be changed. To enable the default http_server, we tested the negated setting of features awc_client.
Cargo allows you to reference a crate from a local or remote git repository. By changing the Cargo.toml to a remote branch, I was able to determine which method is panicking.
The Cargo.toml change:
Running the tests produced.