Skip to content

Conversation

olvlvl
Copy link
Owner

@olvlvl olvlvl commented Jun 11, 2025

Running the collector within Composer's realm is causing issues when the interfaces used by Composer are incompatible with those used by the codebase, as reported by #31 and #32. With these changes, the collector now runs as a separate command, which should solve the issues.

@coveralls
Copy link

coveralls commented Jun 11, 2025

Pull Request Test Coverage Report for Build 15704924121

Details

  • 42 of 47 (89.36%) changed or added relevant lines in 4 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 91.949%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Collector.php 37 38 97.37%
src/Plugin.php 3 7 42.86%
Files with Coverage Reduction New Missed Lines %
src/MemoizeAttributeCollector.php 4 88.24%
Totals Coverage Status
Change from base Build 15704737339: -0.3%
Covered Lines: 434
Relevant Lines: 472

💛 - Coveralls

@olvlvl olvlvl self-assigned this Jun 11, 2025
@olvlvl olvlvl added the enhancement New feature or request label Jun 11, 2025
@olvlvl olvlvl force-pushed the run-as-command branch 5 times, most recently from b2d93e6 to f07246d Compare June 11, 2025 09:14
@olvlvl olvlvl changed the title Run as command Run the collector as a command Jun 11, 2025
@olvlvl olvlvl force-pushed the run-as-command branch 2 times, most recently from c671536 to 4244c93 Compare June 17, 2025 09:03
@olvlvl olvlvl modified the milestones: v3.0.0, v2.1.0 Jun 17, 2025
@olvlvl olvlvl changed the base branch from main to 2.1 June 17, 2025 10:15
@olvlvl olvlvl force-pushed the run-as-command branch 2 times, most recently from d977546 to 1e4ca43 Compare June 17, 2025 10:29
@olvlvl olvlvl merged commit dc2c053 into 2.1 Jun 17, 2025
12 checks passed
@olvlvl olvlvl deleted the run-as-command branch June 17, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants