ngInject not being transformed when directive controller is inside of directive closure

[johnpapa]

When a directive uses a controller and that controller needs // @ngInject syntax it is not being caught when it is defined within the directive closure.

(function () {
    'use strict';

    angular
        .module('app')
        .directive('foo', foo);

    /**
     * @returns {Object} - Directive definition object
     */
    function foo() {
        return {
            restrict: 'EA',
            scope: true,
            transclude: false,
            templateUrl: 'foo.html',
            controller: FooCtrl
        };

        /**
         * @ngInject
         */
        function FooCtrl($scope) {
            var vm = $scope.bar = {
                timeFormat: 'H:mma'
            };
        }
}
}());

Yet this does work when I moved the controller outside the directive.

(function () {
    'use strict';

    angular
        .module('app')
        .directive('foo', foo);

    /**
     * @returns {Object} - Directive definition object
     */
    function foo() {
        return {
            restrict: 'EA',
            scope: true,
            transclude: false,
            templateUrl: 'foo.html',
            controller: FooCtrl
        };
    }

    /**
     * @ngInject
     */
    function FooCtrl($scope) {
        var vm = $scope.bar = {
            timeFormat: 'H:mma'
        };
    }
}());

[olov]

I'm not sure I'm following what you mean with "not being caught" - can you please provide me the output you would have expected (for a given example)? I ran the first example through ng-annotate and it added FooCtrl.$inject = ["$scope"]; as expected.

[johnpapa]

interesting ... i ran that first example through the current ng annotate
and it did not generate the inject.

is the latest build you just did last night now deployed? maybe that fixed
it? is it ready so i can try it?

[olov]

ng-annotate 0.9.9 (current npm version, released 4 days ago) adds the $inject array when I run it on your first example (this is not depending on the not-yet-released code in HEAD). (ng-annotate -a tests-issues/issue62.js). Can you retry and provide downloadable (in case formatting is part of the issue) input and output files if the problem persists?

Which OS do you use?

[johnpapa]

OK, so I tracked this down to using Uglify. It seems that uglifyjs2 will remove code it thinks is unreachable. So in my example ngAnnotate worked, but uglify saw that the $inject statement was after a return statement. So it removed it.

Uglify can be set to allow funcs and vars to be hoisted, but it wont allow Ctrl.$inject = [''] so it removes it. This is not an ngAnnotate issue, so we can close this. But it's a problem unless there is an option to tell it not to do this. I'm doing this thru grunt.

[olov]

Aah, this is actually a problem with ng-annotate because the FooCtrl.$inject = .. annotation as inserted by ng-annotate is truly unreachable. For your example to work ng-annotate must move the annotation to the top of foo instead. I'll open another issue with a minimal test case.

Thanks for finding and reporting the problem!

Example output follows:

(function () {
    'use strict';

    angular
        .module('app')
        .directive('foo', foo);

    /**
     * @returns {Object} - Directive definition object
     */
    function foo() {
        return {
            restrict: 'EA',
            scope: true,
            transclude: false,
            templateUrl: 'foo.html',
            controller: FooCtrl
        };

        /**
         * @ngInject
         */
        function FooCtrl($scope) {
            var vm = $scope.bar = {
                timeFormat: 'H:mma'
            };
        }
        FooCtrl.$inject = ["$scope"]; // <== this line cannot be reached
    }
}());

[johnpapa]

Cool. One of the things I prefer with $inject is to put it immediately before the function. When it is at the bottom it in un minified form I always have to scroll down to see if it is there. So for readability I prefer to put it at top, when I write it myself. So this would also be a cool side effect.

Looking forward to testing your fix.

[johnpapa]

Should this be re-opened, I don't believe it is fixed currently?

[olov]

fixed in 0.10