fix: initialize the last 4 bytes of mem to zero#149
Draft
filmil wants to merge 1 commit intoolofk:mainfrom
Draft
fix: initialize the last 4 bytes of mem to zero#149filmil wants to merge 1 commit intoolofk:mainfrom
mem to zero#149filmil wants to merge 1 commit intoolofk:mainfrom
Conversation
These last 4 bytes are, in fact, used for register `x0`, and must be zero. In multi-valued simulators, however, without an explicit init, these bytes start as undefined. Moving `x0` to anywhere results in those undefined bytes "infecting" other registers. Issue: olofk#148
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These last 4 bytes are, in fact, used for register
x0, and must be zero. In multi-valued simulators, however, without an explicit init, these bytes start as undefined. Movingx0to anywhere results in those undefined bytes "infecting" other registers.Issue: #148