Add additional missing case as well #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncorrect value format
…_handler_rc_fixes
taherkl
approved these changes
Dec 12, 2024
taherkl
added a commit
that referenced
this pull request
Dec 17, 2024
* Type handler (#10) * Added Type Handler for Cassandra * Added UT * PR review comments fixes (#13) * Refectored the code * Handle Minor fixes * Casting fixes PR review comments fixed * Type handler review cm (#14) * updated comments * Add additional missing case as well (#16) * Resolve review comments and added test cases for null, min, max and incorrect value format * Handle Exception * Handle INet * Handle Code Formate * Added format and removeed raw import * Added Null handling * Added test cases for all remaining of cassandra datatype * Address the formatter case * Updated Comment * mvn spotless:apply fixes * Type handler ut fixes (#17) * removed unwanted <> from comments * Added Fixes for String formate * Fix spotapply * Type handler ut fixes (#18) * removed unwanted <> from comments * Added Fixes for String formate * Fix spotapply * Fixed the review comments and add Test with a non-zero offset and happy test * Fixed the review comments and add Test with a non-zero offset and happy test * Handle Sppoty fixes --------- Co-authored-by: Narendra Rajput <narendra.rajput@ollion.com> * Handle Inet from GCP package and also added Long Cast for List of Long * Fix UT and Checklist style * Handle Timestamp to Instant * Fix UT and consolidate Instant Parsing * Handle Fix related 2 date conversion * improved date parsing * Fixed review comments and coverage (#23) * Fixed review comments and increased coverage * ut_coverage_fixes * Fixed UT for Inetaddress --------- Co-authored-by: taherkl <taher.lakdawala@ollion.com> Co-authored-by: pawankashyapollion <v-pawan.kumar@ollion.com> Co-authored-by: Narendra Rajput <narendra.rajput@ollion.com>
pawankashyapollion
added a commit
that referenced
this pull request
Dec 28, 2024
commit f2b54c6 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Thu Dec 26 17:24:16 2024 +0530 Added Casting at runtime commit e1ce3c4 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Thu Dec 26 17:05:56 2024 +0530 Added Collection datatypes and reverse merge fixes commit 8d27081 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Thu Dec 26 16:47:34 2024 +0530 Handle Reverse merge fixes commit 410b1d8 Merge: f565c4a f618128 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Mon Dec 23 16:39:17 2024 +0530 Merge branch 'main' into develop_reverse_merge_with_main commit f565c4a Merge: 5b0c6ad 04bac39 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Mon Dec 23 13:25:51 2024 +0530 Merge branch 'main' into develop_reverse_merge_with_main commit 5b0c6ad Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Wed Dec 18 14:50:48 2024 +0530 Changes Access modifier and also commented Code commit a697607 Merge: 0e7e5ef 7512825 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Wed Dec 18 14:47:26 2024 +0530 Merge branch 'main' into develop_reverse_merge_with_main commit 0e7e5ef Author: Narendra Rajput <narendra.rajput@ollion.com> Date: Tue Dec 17 14:30:26 2024 +0530 Fixed UT for Cassandra DMLGenerator commit 5a0d67c Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Tue Dec 17 13:29:41 2024 +0530 Regenerate the documentaion comment commit 2e313b3 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Tue Dec 17 13:23:48 2024 +0530 Redoder commit bcc214f Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Tue Dec 17 13:16:09 2024 +0530 Move the method at last for readability commit 337edca Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Tue Dec 17 13:11:28 2024 +0530 Added Fixes for Formatter commit 7cf7fce Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Tue Dec 17 13:03:07 2024 +0530 Refector code commit 410a997 Merge: 223d96f 71a6477 Author: taherkl <taher.lakdawala@ollion.com> Date: Mon Dec 16 18:49:53 2024 +0530 Merge branch 'main' into integ_cassandradao_with_dml commit 223d96f Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Mon Dec 16 17:04:32 2024 +0530 Handle set and MAP commit 88349ec Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Mon Dec 16 17:01:12 2024 +0530 Handle Duration case commit d15f96b Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Mon Dec 16 16:47:04 2024 +0530 Added Refector commit be41fda Author: Narendra Rajput <narendra.rajput@ollion.com> Date: Mon Dec 16 15:55:03 2024 +0530 Fixed the Test cases for DMLGenerator commit 9835bb2 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Mon Dec 16 14:06:45 2024 +0530 Handle Formatter commit 7c0d45c Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Mon Dec 16 13:59:06 2024 +0530 Handle Reverse merge and test case fixes commit 979cc0c Merge: 196a6cf 136fa19 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Mon Dec 16 13:55:41 2024 +0530 Merge branch 'cassandra-datatype-handler' into integ_cassandradao_with_dml commit 136fa19 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Mon Dec 16 13:36:10 2024 +0530 improved date parsing commit cce698a Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Mon Dec 16 13:31:52 2024 +0530 Handle Fix related 2 date conversion commit f919de6 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Mon Dec 16 13:17:38 2024 +0530 Fix UT and consolidate Instant Parsing commit 6133427 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Mon Dec 16 13:09:18 2024 +0530 Handle Timestamp to Instant commit 4a8c1ef Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Mon Dec 16 12:49:41 2024 +0530 Fix UT and Checklist style commit 12f457b Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Mon Dec 16 12:36:54 2024 +0530 Handle Inet from GCP package and also added Long Cast for List of Long commit ab9a16f Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Mon Dec 16 12:23:44 2024 +0530 Type handler ut fixes (#18) * removed unwanted <> from comments * Added Fixes for String formate * Fix spotapply * Fixed the review comments and add Test with a non-zero offset and happy test * Fixed the review comments and add Test with a non-zero offset and happy test * Handle Sppoty fixes --------- Co-authored-by: Narendra Rajput <narendra.rajput@ollion.com> commit 196a6cf Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Sun Dec 15 23:18:19 2024 +0530 Added Source and handle source in input record processor commit daee382 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Sun Dec 15 23:08:58 2024 +0530 Added Formatter commit be1e906 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Sun Dec 15 23:06:07 2024 +0530 added CassandraConfigFileReader commit 8765772 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Sun Dec 15 23:04:26 2024 +0530 Added Shard Reader commit 16ff5b0 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Sun Dec 15 22:57:24 2024 +0530 Handle Cassandra DAO commit 050fece Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Sun Dec 15 22:45:33 2024 +0530 Added Helper commit 34919a1 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Sun Dec 15 22:28:06 2024 +0530 Handle Value object stream commit af2bc26 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Sun Dec 15 22:25:22 2024 +0530 Handle Cassandra DAO and POM Configuration commit 866617e Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Sun Dec 15 21:46:20 2024 +0530 formatted according to google Formatter commit e5c1a44 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Sun Dec 15 21:45:31 2024 +0530 reorder changes commit 438b6cd Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Sun Dec 15 21:41:34 2024 +0530 Removed Unwanted import commit 92fd2d5 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Sun Dec 15 21:38:08 2024 +0530 remove collection type as it is not fully accurate commit 04233e4 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Sun Dec 15 21:36:28 2024 +0530 Handle Case for Null commit 99449ee Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Sun Dec 15 21:34:49 2024 +0530 Handle Collection Type commit 09d44ac Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Sun Dec 15 20:26:59 2024 +0530 Added Conversion commit 14b5370 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Fri Dec 13 18:25:57 2024 +0530 Type handler ut fixes (#17) * removed unwanted <> from comments * Added Fixes for String formate * Fix spotapply commit 61f7c58 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Fri Dec 13 18:07:32 2024 +0530 mvn spotless:apply fixes commit 957b886 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Fri Dec 13 17:45:50 2024 +0530 Updated Comment commit 865e970 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Fri Dec 13 17:11:34 2024 +0530 Address the formatter case commit c31e237 Author: Narendra Rajput <narendra.rajput@ollion.com> Date: Fri Dec 13 15:26:01 2024 +0530 Fixed all the imports for Assert and TypeHandler commit fe06164 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Fri Dec 13 14:40:57 2024 +0530 Added access modifier commit bc6f0eb Merge: 7e53896 b3ed3a7 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Fri Dec 13 14:34:21 2024 +0530 Merge branch 'type_handler_rc_fixes' into dml_type_handler_wire_up_with_ut commit 7e53896 Author: Narendra Rajput <narendra.rajput@ollion.com> Date: Fri Dec 13 12:28:02 2024 +0530 Fixed all the Unit test cases for DMLTypeHandler commit d0921bf Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Thu Dec 12 18:44:31 2024 +0530 Add additional missing case as well (#16) * Resolve review comments and added test cases for null, min, max and incorrect value format * Handle Exception * Handle INet * Handle Code Formate * Added format and removeed raw import * Added Null handling * Added test cases for all remaining of cassandra datatype commit b3ed3a7 Merge: 571bfab bd38fbf Author: Narendra Rajput <narendra.rajput@ollion.com> Date: Thu Dec 12 18:35:23 2024 +0530 Merge remote-tracking branch 'origin/type_handler_rc_fixes' into type_handler_rc_fixes commit 571bfab Author: Narendra Rajput <narendra.rajput@ollion.com> Date: Thu Dec 12 18:34:58 2024 +0530 Added test cases for all remaining of cassandra datatype commit bd38fbf Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Thu Dec 12 18:06:52 2024 +0530 Added Null handling commit 58152f7 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Thu Dec 12 16:24:50 2024 +0530 Added format and removeed raw import commit 25f4891 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Thu Dec 12 16:21:01 2024 +0530 Handle Code Formate commit 45e6a58 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Thu Dec 12 15:55:48 2024 +0530 Handle INet commit a241cf9 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Thu Dec 12 15:54:33 2024 +0530 Handle Exception commit c918106 Author: Narendra Rajput <narendra.rajput@ollion.com> Date: Thu Dec 12 15:08:09 2024 +0530 Resolve review comments and added test cases for null, min, max and incorrect value format commit a7d560c Author: Narendra Rajput <narendra.rajput@ollion.com> Date: Thu Dec 12 11:47:02 2024 +0530 Added more Json file and fixed UT commit 92e111f Author: Narendra Rajput <narendra.rajput@ollion.com> Date: Wed Dec 11 20:29:42 2024 +0530 Added Json file and fixed UT commit 44a4e83 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Wed Dec 11 17:22:13 2024 +0530 Added New types here commit cdc1110 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Wed Dec 11 17:07:09 2024 +0530 fix test case and formatter commit df03124 Merge: 68624c9 b58c831 Author: Narendra Rajput <narendra.rajput@ollion.com> Date: Wed Dec 11 15:43:26 2024 +0530 Merge remote-tracking branch 'origin/dml_type_handler_wire_up_with_ut' into dml_type_handler_wire_up_with_ut # Conflicts: # v2/spanner-to-sourcedb/src/test/java/com/google/cloud/teleport/v2/templates/dbutils/dml/CassandraDMLGeneratorTest.java commit 68624c9 Author: Narendra Rajput <narendra.rajput@ollion.com> Date: Wed Dec 11 15:42:11 2024 +0530 Fixed UT for Cassandra DMLGenerator commit d42de96 Author: Narendra Rajput <narendra.rajput@ollion.com> Date: Tue Dec 10 18:24:51 2024 +0530 Test cases for Cassandra DMLGenerator commit 416d1c6 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Wed Dec 11 11:31:50 2024 +0530 nomeclracture changes commit 366db8b Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Wed Dec 11 11:30:17 2024 +0530 Added Comments commit b099719 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Wed Dec 11 11:29:20 2024 +0530 Some minor tweek commit a334310 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Wed Dec 11 11:23:40 2024 +0530 REmoved NULL CASE commit a9fd66e Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Wed Dec 11 11:21:21 2024 +0530 Address Casting commit 05d1ecf Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Wed Dec 11 11:17:40 2024 +0530 Handle Prepared in Generic Way commit b58c831 Author: Narendra Rajput <narendra.rajput@ollion.com> Date: Tue Dec 10 18:24:51 2024 +0530 Test cases for Cassandra DMLGenerator commit d2f8f87 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Tue Dec 10 11:55:53 2024 +0530 Type handler review cm (#14) * updated comments commit 5f9affa Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Tue Dec 10 11:48:14 2024 +0530 PR review comments fixes (#13) * Refectored the code * Handle Minor fixes * Casting fixes PR review comments fixed commit fb67b45 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Tue Dec 10 06:19:55 2024 +0530 Address Source type conversion with missing endpoint commit c891fed Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Tue Dec 10 06:08:01 2024 +0530 Added DML Generated commit af26e98 Author: Taher Lakdawala <78196491+taherkl@users.noreply.github.com> Date: Mon Dec 9 15:11:04 2024 +0530 Type handler (#10) * Added Type Handler for Cassandra * Added UT commit e5069ad Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Mon Dec 9 11:48:37 2024 +0530 Rename to Cassandra TYpe Handler commit f30c25d Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Mon Dec 9 11:38:35 2024 +0530 Added Proper comments commit d2acfb3 Author: Narendra Singh <narendra.rajput@ollion.com> Date: Thu Dec 5 18:07:41 2024 +0530 Unit Test cases for TypeHandler commit 54306e9 Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Thu Dec 5 10:13:26 2024 +0530 Added UT and as of now convert all method to public to write UT commit 5001f8c Author: pawankashyapollion <v-pawan.kumar@ollion.com> Date: Thu Dec 5 10:04:55 2024 +0530 Added Type Handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.