-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Version 1.0 of the request-derived context #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ollieread
wants to merge
6
commits into
main
Choose a base branch
from
draft/v1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a12b08d
chore: Updated the pattern to be more consistent with existing patter…
ollieread cac059d
chore: Add force in the pattern definition
ollieread 8c23e0c
fix: Fix spelling and grammar issues
ollieread 2e070da
chore: Grammar changes and tidy up for clarity
ollieread 7f52cb0
chore: First part of the solution section
ollieread 8888597
chore: Tidy-up note about DB driven services
ollieread File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"resolved" is a funny word, because it could be understood to mean completely understood; whereas multi-request context requires that it isn't finalised. Think "Cookes are resolved" which means they're fully decoded, but does not mean they are appended to the response.
Not sure what the better wording is, though. Context is recognised? Loaded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed "must" to "may" locally, to address this specific concern. The context can be resolved at any point, but in some cases it may need to be resolved early.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@assertchris
Core decisions at both the application and domain level will often depend on context, which means it may be
resolved early on, so the request can be processed correctly.
The pattern must allow for both early and late resolution of context, whether eager or lazy.